fix(docs): correct command merge comment to match union behavior #11310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment claimed "Global state takes precedence over workspace configuration" but the implementation unions both sources via Set with no override logic. Updated to accurately describe the combine and deduplicate behavior.
0xMink
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
size:XS
Contributor
No issues found. The updated comment accurately reflects the Set union behavior in Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11309
Description
The comment above the command merge logic in
mergeCommandLists()states that global state "takes precedence over workspace configuration." The implementation performs a Set union with no override logic — neither source takes precedence. Updated the comment to accurately describe the combine and deduplicate behavior.No functional changes.
Test Procedure
N/A (comment-only change)
Pre-Submission Checklist
Screenshots / Videos
N/A — no UI changes
Documentation Updates
Get in Touch
0xMink
Important
Corrects comment in
mergeCommandLists()inClineProvider.tsto accurately describe command merging behavior as a set union without precedence.mergeCommandLists()inClineProvider.tsto reflect actual behavior of combining and deduplicating commands from global state and workspace configuration.This description was created by
for 51cedcd. You can customize this summary. It will automatically update as commits are pushed.